Do not check for iptables module. - #88
Merged
Merged
Conversation
added 2 commits
August 28, 2026 13:01
The module pre-requisites checks include a check for the iptables module. As of NILRT 26.8, iptables is no longer installed. And we do not actually need it for SNAC. So drop the check. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
The current warning messages are formatted to look like python logging warnings, which makes it somewhat easier to ignore. Instead, output it as a specially-formatted warning text block that is more obviously a message from the developers. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
amstewart
force-pushed
the
dev/iptables-fix
branch
from
September 4, 2026 20:24
991263d to
51802e9
Compare
There is an issue with the backend Azure PR test VM which will take a little time to fix. Temporarily disable this pipeline to unblock PR merges in the mean time. Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
amstewart
force-pushed
the
dev/iptables-fix
branch
from
September 4, 2026 21:05
51802e9 to
516c2e1
Compare
Collaborator
Author
Patch v2
|
AlexHearnNI
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The module pre-requisites checks include a check for the iptables
module. As of NILRT 26.8, iptables is no longer installed. And we do not
actually need it for SNAC. So drop the check.
Also make the warning message at the start of
nilrt-snac configurea little more noticeable.Justification
AB#4007929
AB#4022655
Testing
iptables.Procedure